[TRTLLM-14620][feat] Add confidence-guided dynamic verification for DeepSeek-V4 DSpark - #18392
Draft
zhaoyuanh-nvidia wants to merge 22 commits into
Draft
[TRTLLM-14620][feat] Add confidence-guided dynamic verification for DeepSeek-V4 DSpark#18392zhaoyuanh-nvidia wants to merge 22 commits into
zhaoyuanh-nvidia wants to merge 22 commits into
Conversation
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
Signed-off-by: Zhaoyuan He <zhaoyuanh@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
This draft adds opt-in confidence-guided dynamic verification for DeepSeek-V4 DSpark in the PyTorch runtime.
Static DSpark verifies the full K5 block for every request. The new path uses the checkpoint confidence head to predict prefix survival, selects a profitable measured
(G,V)cell, and allocates the verifier-token budget raggedly across requests.Gis the rank-local CUDA-graph row count andVis the rank-local verifier-token budget.The implementation:
(G,V)across ranks, avoiding a second synchronization round;This is intentionally a draft for architecture and correctness review. The matched static / feature-on forced-K5 / real-dynamic / trailing-static benchmark on the current PR head is still in progress. Therefore, this PR does not yet make a production performance claim. Matched stochastic-output, KV-state, graph-reuse, and rank-agreement validation remain release gates.
The new configuration fields are opt-in and should carry the
api-compatiblelabel.Test Coverage
247e2334(487 passed, 9 warnings), covering planner and tier selection, ragged allocation, attention-DP agreement, CUDA-graph routing, sparse-row geometry, fused-Q handling, KV ownership and rewind, sampling, runtime controls, and static warmup without a speculative worker.592a1ed6: AWS-PDX (171 passed, 10 warnings) and BIA (171 passed, 12 warnings).PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.