[https://nvbugs/6668807][fix] Remove invalid GLM KV cache assertion - #18374
[https://nvbugs/6668807][fix] Remove invalid GLM KV cache assertion#18374yizhang-nv wants to merge 1 commit into
Conversation
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
|
/bot run --disable-fail-fast --stage-list "DGX_B200-8_GPUs-PyTorch-1, DGX_B200-8_GPUs-PyTorch-2, DGX_B200-8_GPUs-PyTorch-3, DGX_B200-8_GPUs-PyTorch-4" |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe GLM-5.2 NVFP4 integration test no longer requires KV-cache manager version 2. Its skip entry was also removed. NVFP4 validation and GSM8K evaluation remain unchanged. ChangesGLM-5.2 NVFP4 test
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change removes an invalid GLM-5.2 frontend assertion and its test waiver so the accuracy test can run again; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #69986 [ run ] triggered by Bot. Commit: |
|
PR_Github #69986 [ run ] completed with state
|
Dev Engineer Review
QA Engineer Review
TestGLM52::test_nvfp4intests/integration/defs/accuracy/test_llm_api_pytorch.py.tests/integration/test_lists/waives.txt.Description
Remove the invalid frontend assertion for GLM-5.2's KV cache manager version. The frontend
llm.argsintentionally retains the"auto"sentinel, while model loading resolves GLM's model preference to KV cache manager V2 inside the worker.Remove the corresponding NVBug 6668807 waiver so the GLM-5.2 NVFP4 accuracy test runs again.
Test Coverage
accuracy/test_llm_api_pytorch.py::TestGLM52::test_nvfp4[tp_size=8-ep_size=8]will be exercised by the DGX B200 8-GPU PyTorch pre-merge stage.PR Checklist
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.