[None][feat] GDS support, direct disk->gpu onboarding#16235
Draft
reasonsolo wants to merge 4 commits into
Draft
Conversation
Adds KVCacheMetrics class with interval-resettable counters for offload/onboard/host_dropped blocks+bytes per pool group. Logs every TRTLLM_KV_METRICS_INTERVAL_S seconds (default 30s) via a daemon thread. Signed-off-by: Lizhi Zhou <lizhiz@im-gb300-login-02.gb300.internal>
… emits
The metrics logger was logging.getLogger("tensorrt_llm.kv_cache_metrics") --
under the "tensorrt_llm" root, disconnected from the "TRT-LLM"-prefixed logger
that sets propagate=False and owns the only stdout StreamHandler. Its INFO
records fell through to the handler-less root and never appeared (0 lines in the
ctx logs despite the daemon thread running every interval). Route the metrics
lines through the TRT-LLM logger directly via a thin shim so they reach the same
stdout as the rest of the server output.
Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.