[None][fix] Propagate NCCL_INCLUDE_DIR to common header dirs#16216
Open
lucifer1004 wants to merge 1 commit into
Open
[None][fix] Propagate NCCL_INCLUDE_DIR to common header dirs#16216lucifer1004 wants to merge 1 commit into
lucifer1004 wants to merge 1 commit into
Conversation
build_wheel.py exposes --nccl_root and FindNCCL honors it, but the located NCCL_INCLUDE_DIR was never propagated to compilation: nccl.h is included from common/opUtils.h whenever ENABLE_MULTI_DEVICE is on, including by targets that do not link NCCL::nccl. Builds only worked when nccl.h happened to sit in the compiler's default search path (as in the release containers), so pointing --nccl_root at an NCCL installed anywhere else failed with 'nccl.h: No such file or directory'. Append the found include directory to COMMON_HEADER_DIRS so --nccl_root is usable end to end. Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Zihua Wu <13583761+lucifer1004@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CMake configuration now appends ChangesMulti-device build configuration
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building against a custom NCCL via
--nccl_root(e.g. the pipnvidia-nccl-cu13wheel, whose headers do not live in a compiler default path), FindNCCL resolvesNCCL_INCLUDE_DIRcorrectly but the directory is never added to the compile include paths — multi-device translation units then fail withnccl.h: No such file or directoryeven though configure succeeded.Append
NCCL_INCLUDE_DIRtoCOMMON_HEADER_DIRSwhenENABLE_MULTI_DEVICEis on. No behavior change for builds whose NCCL headers already sit in default include paths.🤖 Generated with Claude Code
Summary by CodeRabbit