Repository navigation
fix(docker): pin Docker Desktop host gateway - #4404
Open
senthilr-nv wants to merge 1 commit into
Open
senthilr-nv wants to merge 1 commit into
senthilr-nv wants to merge 1 commit into
Conversation
Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
senthilr-nv
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 11, 2026 04:22
|
All contributors have signed the DCO ✍️ ✅ |
Author
|
I have read the DCO document and I hereby sign the DCO. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin Docker Desktop's daemon-owned host-gateway address when the Docker supervisor reaches the gateway through
host.docker.internal. This lets an explicitly allowedhost.openshell.internalendpoint pass the supervisor's trusted-gateway policy check without enabling host networking or weakening DNS trust.Related Issue
Closes #4403
Related to #3880 and completes the named-endpoint host-service limitation documented in #3924.
Changes
host-gatewaytoken through a short-lived, sandbox-labeled helper container only whengrpc_endpointuseshost.docker.internal./etc/hostsentry into one concrete address and reject missing, ambiguous, malformed, unspecified, multicast, broadcast, and metadata addresses.host.openshell.internaltrust pin while preserving literal, loopback, and unrelated named-endpoint behavior.No configuration, default, CLI, or policy-schema contract changes. Existing documentation and agent workflows remain accurate.
Testing
cargo test -p openshell-driver-docker --lib: 139 passed, 1 ignoredopenshell-driver-docker: passedgit diff --check origin/main...HEAD: passedhost-gatewaymappingThe full canary bundled
e7c8a1025. The signed publication commitdca78bdd1changes only commit-signature metadata; both commits have tree5c817db43e74b4c44003f6e1feac741b187a77db.Checklist