Skip to content

perf(supervisor-network): avoid reparsing native policy input #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shiju-nv wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

perf(supervisor-network): avoid reparsing native policy input #2654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions crates/openshell-supervisor-network/src/l7/relay.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1929,7 +1929,7 @@ fn evaluate_l7_request_once(
));
}

let input_json = serde_json::json!({
let input = serde_json::json!({
"network": {
"host": ctx.host,
"port": ctx.port,
Expand All @@ -1953,9 +1953,10 @@ fn evaluate_l7_request_once(
.lock()
.map_err(|_| miette!("OPA engine lock poisoned"))?;

engine
.set_input_json(&input_json.to_string())
.map_err(|e| miette!("{e}"))?;
// Regorus's infallible `From<serde_json::Value>` maps conversion errors to `Undefined`.
// Convert fallibly so failures remain evaluator errors instead of becoming policy input.
let input = serde_json::from_value::<regorus::Value>(input).map_err(|e| miette!("{e}"))?;
engine.set_input(input);

let allowed = engine
.eval_rule("data.openshell.sandbox.allow_request".into())
Expand Down
Loading