feat(gateway): spike runtime settings file#1920
Draft
TaylorMutch wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-1920.docs.buildwithfern.com/openshell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SPIKE: Investigate a general gateway runtime settings file that Kubernetes deployments can use as an authoritative hook for enabling and disabling runtime-level gateway settings without restarting the gateway.
This is intentionally framed as a spike PR. It proposes and exercises one concrete implementation path: a watched runtime settings file referenced from
gateway.toml, reconciled into the existing gateway-global settings row, with Helm support for mounting the file from a ConfigMap.Related Issue
N/A - spike investigation requested directly.
Changes
runtime_config_pathto gateway startup TOML.settings set/delete --globalfor those keys.server.runtimeConfig.*values, a separate runtime ConfigMap template, mounts, and chart tests.Spike Questions
Testing
mise run pre-commitpassescargo test -p openshell-server runtime_config -- --nocapturecargo test -p openshell-server runtime_managed_key -- --nocapturecargo test -p openshell-server config_file::tests::parses_full_example -- --nocapturemise run helm:testmise run helm:docs:checkChecklist