Skip to content

docs(rfc): require issues before RFCs#1918

Open
drew wants to merge 3 commits into
mainfrom
rfc-guidance-updates
Open

docs(rfc): require issues before RFCs#1918
drew wants to merge 3 commits into
mainfrom
rfc-guidance-updates

Conversation

@drew

@drew drew commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

Update RFC guidance so users open GitHub issues before RFCs, maintainers request RFCs only when necessary, and maintainers assign RFC numbers from the originating issue. Also correct stale RFC status metadata for existing RFCs.

Related Issue

None.

Changes

  • Require new features to start from the feature request template rather than RFC PRs.
  • Document maintainer-controlled RFC number assignment from issues.
  • Align the RFC template, contributor guidance, architecture overview, and feature request template.
  • Correct existing RFC front matter statuses: RFC 0000 to accepted, RFC 0001 and RFC 0002 to accepted, RFC 0003 to implemented.

Testing

  • mise run pre-commit passes
    • Attempted, but local toolchain/dependency setup failed before completing: python:proto could not find grpc_tools on its first concurrent run, rust:lint could not build z3-sys because z3.h was missing, and aws-lc-sys failed while Homebrew GCC compiled against a macOS SDK header that uses block syntax.
  • git diff --check passes
  • mise run markdown:lint:md passes
  • Unit tests added/updated (not applicable; docs/template-only)
  • E2E tests added/updated (not applicable; docs/template-only)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew drew requested review from a team, derekwaynecarr and mrunalp as code owners June 15, 2026 23:18
drew added 2 commits June 15, 2026 16:22
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Comment thread rfc/README.md
### 2. Get maintainer confirmation

Look at the existing RFC folders in this directory and choose the next available number. If two authors happen to pick the same number on separate branches, the conflict is resolved during PR review — the later PR simply picks the next available number.
Maintainers decide from the issue whether an RFC is necessary. If it is, they assign the RFC number in the issue before anyone creates the RFC branch or folder. Authors should use the assigned number instead of choosing one locally.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be useful if we could filter for issues/PRs that have RFC assigned, should we mention having the issue tagged with rfc once number is assigned?

That's more of a maintainer instruction, so likely belongs somewhere else. Ideally, it should be easy to tell the agent "Assign the next RFC to issue 1234" and it would know what to do (search existing, find the most recent, add one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants