Skip to content

fix(python): add encoding=utf-8 to file reads and writes in sandbox.py #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mesutoezdil wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix(python): add encoding=utf-8 to file reads and writes in sandbox.py #1912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions python/openshell/sandbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ def from_active_cluster(
gateway_dir = _xdg_config_home() / "openshell" / "gateways" / cluster_name
metadata_path = gateway_dir / "metadata.json"
try:
metadata = json.loads(metadata_path.read_text())
metadata = json.loads(metadata_path.read_text(encoding="utf-8"))
except FileNotFoundError:
raise SandboxError(f"gateway '{cluster_name}' not found") from None
if "gateway_endpoint" not in metadata:
Expand Down Expand Up @@ -846,7 +846,7 @@ def _read_oidc_token_bundle(gateway_dir: pathlib.Path) -> dict | None:
"""
token_path = gateway_dir / "oidc_token.json"
try:
return json.loads(token_path.read_text())
return json.loads(token_path.read_text(encoding="utf-8"))
except FileNotFoundError:
return None
except (OSError, json.JSONDecodeError):
Expand Down Expand Up @@ -1299,7 +1299,7 @@ def _write_to_disk(self, bundle: dict) -> None:
)
tmp_path = pathlib.Path(tmp_name)
try:
with os.fdopen(fd, "w") as f:
with os.fdopen(fd, "w", encoding="utf-8") as f:
f.write(payload)
with contextlib.suppress(OSError):
tmp_path.chmod(0o600)
Expand Down Expand Up @@ -1374,7 +1374,7 @@ def _resolve_active_cluster() -> str:
return env_gateway
active_file = _xdg_config_home() / "openshell" / "active_gateway"
try:
value = active_file.read_text().strip()
value = active_file.read_text(encoding="utf-8").strip()
except FileNotFoundError:
raise SandboxError("no active gateway configured") from None
if value == "":
Expand Down
Loading