ci(e2e): reuse prebuilt gateway binaries#1910
Open
krishicks wants to merge 1 commit into
Open
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Label |
Build OpenShell gateway and CLI binaries once in the reusable e2e workflow and share them with matrix jobs. This avoids having each e2e job having to compile the binaries independently. Teach the e2e gateway helpers and entrypoints to consume prebuilt binary paths when provided, while preserving local source-build behavior. Signed-off-by: Kris Hicks <khicks@nvidia.com>
krishicks
force-pushed
the
hicks/push-urtwvrnzqozu
branch
from
0db3b4f to
0012a0d
Compare
krishicks
requested review from
a team,
derekwaynecarr and
mrunalp
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build OpenShell gateway and CLI binaries once in the reusable e2e workflow and share them with matrix jobs. This avoids having each e2e job having to compile the binaries independently. This is partly because it's the right thing to do (why waste compute?), but it also makes re-running e2e jobs faster, and makes the log output much more directed because it's just the test output, not also the very large output from compiling the binary(s).
Teach the e2e gateway helpers and entrypoints to consume prebuilt binary paths when provided, while preserving local source-build behavior.
Related Issue
Changes
Testing
mise run pre-commitpassesChecklist