fix(server): retry sandbox delete phase conflicts#1905
Open
TaylorMutch wants to merge 1 commit into
Open
Conversation
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
|
Label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retry transient sandbox
resource_versionconflicts while moving a sandbox intoDeletingduringDeleteSandbox. This prevents a cleanup-time CAS conflict from leaving provider-attached sandbox records behind and causing provider deletion to fail afterward.Related Issue
Fixes #1517
Changes
Conflicterrors before backend driver deletion.Deleting.Testing
cargo test -p openshell-server set_sandbox_phase_deleting_retries_after_stale_snapshot_conflictcargo test -p openshell-server delete_provider_rejects_attached_providercargo test -p openshell-server compute::tests::mise run pre-commitpassesmise run pre-commitwas run and failed on checks unrelated to this patch:python:format:checkwants to reformattasks/scripts/sync_docs_website.py, andhelm:lintreports missing chart dependency metadata forpostgresql. Rust format/check/lint completed successfully inside that run.Checklist