Add cohesive gateway registration commands - #28
Merged
johnnygreco merged 5 commits intoJul 29, 2026
Conversation
Documentation previewThe preview has been removed. |
johnnygreco
force-pushed
the
johnny/privacy-guard-gateway-registration-commands
branch
from
July 29, 2026 17:15
61085a0 to
75cfaa4
Compare
johnnygreco
marked this pull request as ready for review
July 29, 2026 18:51
johnnygreco
deleted the
johnny/privacy-guard-gateway-registration-commands
branch
July 29, 2026 19:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
add-gateway-registrationremove-gateway-registration --name NAMEwith the same config-path resolutionWhy
Privacy Guard could add or update a named OpenShell gateway middleware registration, but had no matching way to remove one. The paired command names now make the lifecycle explicit and cohesive.
User impact
Operators can add and remove Privacy Guard registrations without hand-editing gateway TOML. Removing a missing registration is a successful no-op; duplicate named registrations fail safely.
Validation
make check(252 tests; formatting, lint, typing, import, build, and dependency audit)python3 tests/test_render_dev_notes.pyscripts/build-docs.shPanel review
Three independent reviewers covered configuration correctness and safety, CLI/API maintainability and operator experience, and tests/docs/integration. Review findings around TOML source boundaries, comment preservation, structural post-state validation, and recovery errors were fixed. The final focused re-review was clean.