Skip to content

Multimodal: Limit transformer version in Dockerfile#3448

Merged
janEbert merged 3 commits intoNVIDIA:mainfrom
IanBoyanZhang:multimodal-docker-update
Feb 26, 2026
Merged

Multimodal: Limit transformer version in Dockerfile#3448
janEbert merged 3 commits intoNVIDIA:mainfrom
IanBoyanZhang:multimodal-docker-update

Conversation

@faradawn
Copy link
Copy Markdown
Contributor

What does this PR do ?

The current dockerfile does not contain certain packages like setuptools, which caused the build to fail on some devices.

More importantly, the transformer version is not below 5.0.0, which introduces breaking change.

This PR fixes the issue and has successfully performed the conversion of a llama model.

  [2026-02-17 00:38:01.616338] successfully saved checkpoint from iteration       1 to ./converted_mistral [ t 1/1, p 1/1 ]

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Feb 17, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g ko3n1g requested a review from a team February 17, 2026 00:46
@janEbert
Copy link
Copy Markdown
Contributor

/ok to test 50dcad4

Signed-off-by: nvidia <nvidia@TRY-64956-gpu01.nvidialaunchpad.com>
@janEbert janEbert force-pushed the multimodal-docker-update branch from 50dcad4 to f70d47a Compare February 20, 2026 18:13
@faradawn
Copy link
Copy Markdown
Contributor Author

/ok to test 2318cfc

@janEbert janEbert added this pull request to the merge queue Feb 26, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22455400401

@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22456323696

Merged via the queue into NVIDIA:main with commit 7e3f670 Feb 26, 2026
52 of 53 checks passed
BoxiangW pushed a commit to BoxiangW/Megatron-LM that referenced this pull request Mar 4, 2026
Signed-off-by: nvidia <nvidia@TRY-64956-gpu01.nvidialaunchpad.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants