Skip to content

Use std::optional instead of direct default argument for LaunchParams #5980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdspring1 merged 1 commit into from
Feb 19, 2026
+13 −6
Merged

Use std::optional instead of direct default argument for LaunchParams #5980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions python/python_direct/runtime.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,13 +516,15 @@ void bindKernelExecutor(py::module& nvfuser) {
[](KernelExecutor& self,
Fusion* fusion,
const py::iterable& args,
const LaunchParams& launch_constraints,
std::optional<LaunchParams> launch_constraints,
const CompileParams& compile_params,
SchedulerType scheduler_type) {
// launch_constraints is optional to avoid creating default
// LaunchParams when importing shared library.
self.compile(
fusion,
from_pyiterable(args),
launch_constraints,
launch_constraints.value_or(LaunchParams()),
compile_params,
scheduler_type);
},
Expand All @@ -548,17 +550,22 @@ void bindKernelExecutor(py::module& nvfuser) {
)",
py::arg("fusion"),
py::arg("args") = py::list(),
py::arg("launch_constraints") = LaunchParams(),
py::arg("launch_constraints") = py::none(),
py::arg("compile_params") = CompileParams(),
py::arg("scheduler_type") = SchedulerType::None)
.def(
"run",
[](KernelExecutor& self,
const py::iterable& args,
const LaunchParams& launch_constraints,
std::optional<LaunchParams> launch_constraints,
const CompileParams& compile_params) {
// launch_constraints is optional to avoid creating default
// LaunchParams when importing shared library.
KernelArgumentHolder outputs = self.run(
from_pyiterable(args), {}, launch_constraints, compile_params);
from_pyiterable(args),
{},
launch_constraints.value_or(LaunchParams()),
compile_params);
return to_tensor_vector(outputs);
},
R"(
Expand All @@ -579,7 +586,7 @@ void bindKernelExecutor(py::module& nvfuser) {
The output arguments containing the results.
)",
py::arg("args"),
py::arg("launch_constraints") = LaunchParams(),
py::arg("launch_constraints") = py::none(),
py::arg("compile_params") = CompileParams())
.def(
"is_compiled",
Expand Down