You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The operator<< function directly dereferences info.p_sharded_id and info.c_sharded_id without checking if they are null. This could cause segmentation faults if these pointers are null when the operator is called. Consider adding null checks or using safe pointer printing methods.
The header file declares operator<< with std::ostream& parameter but doesn't include or . This may cause compilation issues depending on what includes are already present in the file.
Added a std::ostream operator<< overload for the CommunicationInfo struct to enable printing for debugging purposes.
Declared the operator in lower_to_communication.h
Implemented the operator in lower_to_communication.cpp to print the communication type and producer/consumer sharded IDs
The implementation correctly leverages existing operator<< for CommunicationType and Statement* (which IterDomain* inherits from)
Confidence Score: 5/5
This PR is safe to merge with minimal risk
This is a simple debugging utility addition that adds a stream operator for a struct. The implementation is correct, follows existing patterns in the codebase (using existing operator<< for CommunicationType and Statement*), and has no side effects on functionality.
No files require special attention
Important Files Changed
Filename
Overview
csrc/host_ir/lower_to_communication.h
Added operator<< declaration for CommunicationInfo struct
csrc/host_ir/lower_to_communication.cpp
Implemented operator<< for CommunicationInfo struct to print type and sharded IDs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.