chore(guardrails): speed up IGW middleware integration test fixtures#37
Draft
albcui wants to merge 1 commit into
Draft
Conversation
Contributor
|
Signed-off-by: Albert Cui <contact@albertcui.dev>
albcui
force-pushed
the
albcui/AIRCORE-585/speed-up-igw-middleware-integration-test-fixtures-by-module-scoping
branch
from
ee440ae to
5487740
Compare
albcui
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Big idea: convert the heavy ASGI stack from function-scoped to module-scoped, so that they can be re-used across tests. The heavy stuff includes:
Results using
time -p ...--dist=loadfile -n 4The main speedup is experienced when you run the tests sequentially. This is often the case when you are in a dev loop and just running locally with
pytest .... The change is less noticeable when you usexdist, which already parallelizes the per-test rebuild across workers, so module-scoping on top yields less benefits.