-
Notifications
You must be signed in to change notification settings - Fork 93
feat: add KubeflowExecutor for Kubeflow Training Operator (TrainJob CRD) #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ko3n1g
wants to merge
16
commits into
main
Choose a base branch
from
feat/pytorchjob-executor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
17d1ae6
feat: add KubeflowExecutor for Kubeflow Training Operator on Kubernetes
ko3n1g 4872ad7
fix: scope PVC writes to <username>/code and fix launch script path r…
ko3n1g ab9aabe
fix: expose all replicas in describe() and improve test coverage
ko3n1g fc6cb44
fix: address code review comments (autoescape note, empty except comm…
ko3n1g 446bead
feedback
ko3n1g e10da5e
num_nodes: int = 1
ko3n1g ff80ab6
alpine
ko3n1g 7cac072
refactor: remove PyTorchJob support from KubeflowExecutor
ko3n1g e8b68af
fix: handle legacy job_kind field when deserializing persisted execut…
ko3n1g d675e8d
fix: also migrate legacy nproc_per_node field when deserializing exec…
ko3n1g 4e1a307
chore: remove backwards compat shims for job_kind and nproc_per_node
ko3n1g cdf9033
fix: add --max-log-requests to kubectl logs for num_nodes > 5
ko3n1g 495a7ad
comment on chmod
ko3n1g bc629c0
typo
ko3n1g 39523c4
fix: make fetch_logs streaming resilient to flaky kubectl exits
ko3n1g 7474d3b
chore: ruff format test_kubeflow.py
ko3n1g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -183,3 +183,4 @@ _version.py | |
|
|
||
| # NeMo Run | ||
| .nemo_run/ | ||
| local/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.