Skip to content

fix: voice agent WebSocket URL host configuration#15813

Open
chtruong814 wants to merge 1 commit into
mainfrom
chtruong/socket
Open

fix: voice agent WebSocket URL host configuration#15813
chtruong814 wants to merge 1 commit into
mainfrom
chtruong/socket

Conversation

@chtruong814

Copy link
Copy Markdown
Collaborator

Summary

  • Stop deriving the voice agent /connect WebSocket URL from the incoming request host.
  • Add trusted SERVER_PUBLIC_HOST and WEBSOCKET_SCHEME configuration for the returned WebSocket URL.
  • Add focused tests for configured host handling and scheme validation.

Validation

  • pytest examples/voice_agent/tests/test_websocket_url.py -q
  • UV_CACHE_DIR=.uv-cache uv run isort --check examples/voice_agent/server/server.py examples/voice_agent/server/websocket_url.py examples/voice_agent/tests/test_websocket_url.py
  • UV_CACHE_DIR=.uv-cache uv run black --check --required-version 26.5.1 examples/voice_agent/server/server.py examples/voice_agent/server/websocket_url.py examples/voice_agent/tests/test_websocket_url.py

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814

Copy link
Copy Markdown
Collaborator Author

/ok to test f39d27c

@chtruong814 chtruong814 requested a review from stevehuang52 June 18, 2026 15:43
@chtruong814 chtruong814 changed the title Fix voice agent WebSocket URL host configuration fix: voice agent WebSocket URL host configuration Jun 18, 2026
@chtruong814 chtruong814 added the r3.0.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge. label Jun 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

[🤖]: Hi @chtruong814 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r3.0.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant