fix: Replace direct hydra.utils.instantiate with safe_instantiate#15802
Open
chtruong814 wants to merge 21 commits into
Open
fix: Replace direct hydra.utils.instantiate with safe_instantiate#15802chtruong814 wants to merge 21 commits into
chtruong814 wants to merge 21 commits into
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Collaborator
Author
|
/ok to test 133f035 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
chtruong814
force-pushed
the
chtruong/safe-instantiate
branch
from
282a633 to
9e65efa
Compare
Collaborator
Author
|
/ok to test 9e65efa |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Collaborator
Author
|
/ok to test 1ec9c06 |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Collaborator
Author
|
/ok to test 4b01c3e |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Collaborator
Author
|
/ok to test 86939e6 |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Collaborator
Author
|
/ok to test c4f81dc |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Collaborator
Author
|
/ok to test 79441a7 |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Collaborator
Author
|
/ok to test 3c83c3b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
fix: Replace direct hydra.utils.instantiate with safe_instantiate
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information