feat(cli): add slurm resource attr export - #53
Merged
Conversation
rhewett-nv
force-pushed
the
rhewett/pr5-slurm-resource-attrs-cli
branch
from
September 3, 2026 18:31
1f5fbcb to
b8255b1
Compare
rhewett-nv
force-pushed
the
rhewett/pr5-slurm-resource-attrs-cli
branch
from
September 3, 2026 18:47
b8255b1 to
ef53d0c
Compare
rhewett-nv
force-pushed
the
rhewett/pr5-slurm-resource-attrs-cli
branch
from
September 3, 2026 19:05
ef53d0c to
1d6b9d1
Compare
rhewett-nv
force-pushed
the
rhewett/pr5-slurm-resource-attrs-cli
branch
2 times, most recently
from
September 3, 2026 20:05
953819e to
fead619
Compare
ahmadki
previously approved these changes
Sep 3, 2026
rhewett-nv
force-pushed
the
rhewett/pr5-slurm-resource-attrs-cli
branch
from
September 4, 2026 00:30
fead619 to
9fa38e0
Compare
rhewett-nv
force-pushed
the
rhewett/pr5-slurm-resource-attrs-cli
branch
from
September 4, 2026 03:58
9fa38e0 to
e151da0
Compare
ahmadki
previously approved these changes
Sep 4, 2026
Member
|
/ok to test e151da0 |
ahmadki
force-pushed
the
rhewett/pr5-slurm-resource-attrs-cli
branch
from
September 4, 2026 14:17
e151da0 to
b2682f5
Compare
Base automatically changed from
rhewett/pr4-provider-participant-attrs
to
main
September 4, 2026 14:33
rhewett-nv
dismissed
ahmadki’s stale review
September 4, 2026 14:33
The merge-base changed after approval.
Signed-off-by: Russell Hewett <rhewett@nvidia.com>
rhewett-nv
force-pushed
the
rhewett/pr5-slurm-resource-attrs-cli
branch
from
September 4, 2026 14:44
b2682f5 to
20da74a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
nemo-lens set-slurm-resource-attrs, an eval-friendly CLI for appendingLens-derived Slurm launch resource attributes to
OTEL_RESOURCE_ATTRIBUTES.Issues
N/A
Usage
Before your PR is "Ready for review"
Pre checks:
git commit -s) per the DCO.tests/for any behavior change.pytestandpre-commit run --all-fileslocally; both pass.docs/andREADME.mdwhere behavior, configuration, or public API changed._fallbacks.pyfiles in Megatron-LM / RL / Gym.Additional information
Validation on
pr5-slurm-resource-attrs-cli:../.venv/bin/pre-commit run --all-files: passedPYTHONPATH=src ../.venv/bin/python -m pytest -q:265 passed, 7 warnings../.venv/bin/python -m compileall -q src tests: passednpm --prefix docs/fern run check: passed with0 errors; one warning because the unauthenticated redirects check is skipped withoutfern login/FERN_TOKENNotes:
eb98291 feat(cli): add slurm resource attr export.OTEL_RESOURCE_ATTRIBUTES.OTEL_RESOURCE_ATTRIBUTESvalues are preserved and take precedenceover locally derived fallback values.
--stage sbatchcaptures scheduler/script-context Slurm attributes such asslurm.head_node.namewhen Slurm exposes them.--stage taskcaptures task-local attributes such ashost.name,slurm.topology.*, and optionalnv.dl.launch.container.image.--container-imageis valid only with--stage task; sbatch usage returns 2.docs/fern/versions/0.1.0/pages are changed, and no top-level Lens API orfallback surface changes are required.