feat(cli): add explicit span emitter - #51
Merged
Merged
Conversation
ahmadki
requested changes
Sep 3, 2026
rhewett-nv
force-pushed
the
rhewett/pr3-emit-spans-cli
branch
2 times, most recently
from
September 3, 2026 18:47
e2e4ce5 to
7c0ef13
Compare
rhewett-nv
force-pushed
the
rhewett/pr3-emit-spans-cli
branch
from
September 3, 2026 19:05
7c0ef13 to
e0105b2
Compare
rhewett-nv
force-pushed
the
rhewett/pr3-emit-spans-cli
branch
from
September 3, 2026 19:28
e0105b2 to
0a0db6d
Compare
rhewett-nv
force-pushed
the
rhewett/pr3-emit-spans-cli
branch
from
September 3, 2026 20:05
0a0db6d to
585420c
Compare
rhewett-nv
force-pushed
the
rhewett/pr3-emit-spans-cli
branch
2 times, most recently
from
September 4, 2026 03:58
96f50a4 to
866e71f
Compare
Member
|
/ok to test 866e71f |
ahmadki
approved these changes
Sep 4, 2026
ahmadki
previously approved these changes
Sep 4, 2026
Signed-off-by: Russell Hewett <rhewett@nvidia.com>
Signed-off-by: Russell Hewett <rhewett@nvidia.com>
ahmadki
force-pushed
the
rhewett/pr3-emit-spans-cli
branch
from
September 4, 2026 14:17
866e71f to
6f43410
Compare
rhewett-nv
dismissed
ahmadki’s stale review
September 4, 2026 14:31
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
nemo-lens emit-spansCLI for exporting completed spans from explicitepoch-second intervals in shell launch workflows.
Issues
N/A
Usage
Before your PR is "Ready for review"
Pre checks:
git commit -s) per the DCO.tests/for any behavior change.pytestandpre-commit run --all-fileslocally; both pass.docs/andREADME.mdwhere behavior, configuration, or public API changed._fallbacks.pyfiles in Megatron-LM / RL / Gym.Additional information
Validation on
pr3-emit-spans-cli:../.venv/bin/pre-commit run --all-files: passedPYTHONPATH=src ../.venv/bin/python -m pytest -q:261 passed, 7 warnings../.venv/bin/python -m compileall -q src tests: passednpm --prefix docs/fern run check: passed with0 errors; one warning because the unauthenticated redirects check is skipped withoutfern login/FERN_TOKENNotes:
0931973 feat(cli): add explicit span emitter.--servicesetsservice.nameand takes precedence overservice.nameinOTEL_RESOURCE_ATTRIBUTES.providers.py;nemo.lens.cliimports successfully withopentelemetry.sdkunavailable.