Implement a fix_convolution method#368
Conversation
Co-authored-by: Felix Hekhorn <felixhekhorn@users.noreply.github.com>
|
With this, I believe this is now done. |
cschwan
left a comment
There was a problem hiding this comment.
I'm not sure the following situation is covered: one PDF + one FF and you integrate out the PDF, thereby getting rid of the factorization scale (logs). Can you check that?
|
This is almost perfect, can you please add the following tests to up the code coverage: call
Ideally we'd also test missing the missing coverage where DIS+FF-grid's first convolution is fixed, but I can imagine creating such a grid isn't easy. |
Added in 2faed55.
Also done in 2faed55. I didn't add it initially because I was lazy xP but actually the Python tests ecosystem allows for such implementations to be done relatively easy. |
The following PR allows fixing one of the convolutions and return a new Grid with lower dimension. For eg. it can be used to convert a SIDIS grid into DIS.
TODO:
cc @vbertone