Add default error branch to getParamCCP() for unknown dataset keys#82
Merged
phoman14 merged 3 commits intoNewFun_CompareCelPopfrom Mar 18, 2026
Merged
Add default error branch to getParamCCP() for unknown dataset keys#82phoman14 merged 3 commits intoNewFun_CompareCelPopfrom
getParamCCP() for unknown dataset keys#82phoman14 merged 3 commits intoNewFun_CompareCelPopfrom
Conversation
Merged
Co-authored-by: phoman14 <21298645+phoman14@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on "New fun compare cel pop" PR
Add default error branch to Mar 18, 2026
getParamCCP() for unknown dataset keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getParamCCP()had no fallback for unrecognizeddatavalues, leavingobjectand column variables undefined and producing confusing downstream errors.Changes
tests/testthat/helper-Compare_Cell_Populations.R: Added anelsebranch thatstop()s immediately with a clear message enumerating the supported dataset keys:💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.