Skip to content

Add explicit else-stop to getParamCCP for unknown dataset names#81

Merged
phoman14 merged 3 commits intoNewFun_CompareCelPopfrom
copilot/sub-pr-80
Mar 18, 2026
Merged

Add explicit else-stop to getParamCCP for unknown dataset names#81
phoman14 merged 3 commits intoNewFun_CompareCelPopfrom
copilot/sub-pr-80

Conversation

Copy link

Copilot AI commented Mar 18, 2026

getParamCCP() had no default branch, so passing an unrecognized data value would silently fall through and produce a confusing "object not found" error at return() rather than a clear failure at the call site.

Change

  • Added an else branch that stop()s immediately with an actionable message listing all supported keys:
} else {
  stop(
    "Unknown dataset '", data, "'. ",
    "Supported datasets are: 'TEC', 'Chariou', 'PBMC', 'NSCLC', 'BRCA'."
  )
}

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Co-authored-by: phoman14 <21298645+phoman14@users.noreply.github.com>
Copilot AI changed the title [WIP] [WIP] Address feedback on new fun compare cel pop PR Add explicit else-stop to getParamCCP for unknown dataset names Mar 18, 2026
Copilot AI requested a review from phoman14 March 18, 2026 01:03
@phoman14
Copy link
Member

Changes Accepted made changes on VSCode

@phoman14 phoman14 marked this pull request as ready for review March 18, 2026 01:17
@phoman14 phoman14 merged commit e13dc63 into NewFun_CompareCelPop Mar 18, 2026
@phoman14 phoman14 deleted the copilot/sub-pr-80 branch March 19, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants