Skip to content

Comments

Task/saet 0000 baseline set up#16

Open
JackCullen-nhs wants to merge 181 commits intodevelopfrom
task/SAET-0000_Baseline_set_up
Open

Task/saet 0000 baseline set up#16
JackCullen-nhs wants to merge 181 commits intodevelopfrom
task/SAET-0000_Baseline_set_up

Conversation

@JackCullen-nhs
Copy link
Collaborator

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

ri-nhs and others added 30 commits February 20, 2026 13:25
id: delete_artefacts
shell: bash
run: |
export WORKSPACE=${{inputs.workspace}}

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this action to not use user-controlled data directly in a run block. See more on SonarQube Cloud
shell: bash
run: |
export WORKSPACE=${{inputs.workspace}}
export ARTEFACT_BUCKET_NAME=${{inputs.artefact_bucket_name}}

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this action to not use user-controlled data directly in a run block. See more on SonarQube Cloud
id: delete_tf_state
shell: bash
run: |
export WORKSPACE=${{inputs.workspace}}

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this action to not use user-controlled data directly in a run block. See more on SonarQube Cloud
shell: bash
run: |
export WORKSPACE=${{inputs.workspace}}
export ENVIRONMENT=${{inputs.environment}}

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this action to not use user-controlled data directly in a run block. See more on SonarQube Cloud
export TRIGGER=${{ github.ref_type }}
export TRIGGER_ACTION=${{ github.event_name }}
export TRIGGER_REFERENCE=${{ github.ref_name }}
export TRIGGER_HEAD_REFERENCE=${{ github.head_ref }}

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this action to not use user-controlled data directly in a run block. See more on SonarQube Cloud
echo "working_directory=services/${{ inputs.name }}" >> $GITHUB_OUTPUT
echo "build_directory=build/services/${{ inputs.name }}" >> $GITHUB_OUTPUT
elif [[ "${{ inputs.build_type }}" == "package" ]]; then
echo "working_directory=application/packages/${{ inputs.name }}" >> $GITHUB_OUTPUT

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this workflow to not use user-controlled data directly in a run block. See more on SonarQube Cloud
echo "build_directory=build/services/${{ inputs.name }}" >> $GITHUB_OUTPUT
elif [[ "${{ inputs.build_type }}" == "package" ]]; then
echo "working_directory=application/packages/${{ inputs.name }}" >> $GITHUB_OUTPUT
echo "build_directory=build/packages/${{ inputs.name }}" >> $GITHUB_OUTPUT

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this workflow to not use user-controlled data directly in a run block. See more on SonarQube Cloud
echo "working_directory=application/packages/${{ inputs.name }}" >> $GITHUB_OUTPUT
echo "build_directory=build/packages/${{ inputs.name }}" >> $GITHUB_OUTPUT
else
echo "Invalid build type: ${{ inputs.build_type }}"

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this workflow to not use user-controlled data directly in a run block. See more on SonarQube Cloud
name: Cleardown Infrastructure

permissions:
id-token: write

Check notice

Code scanning / SonarCloud

Write permissions should be defined at the job level Low

Move this write permission from workflow level to job level. See more on SonarQube Cloud

permissions:
id-token: write
contents: read

Check notice

Code scanning / SonarCloud

Read permissions should be defined at the job level Low

Move this read permission from workflow level to job level. See more on SonarQube Cloud
@JackCullen-nhs JackCullen-nhs force-pushed the task/SAET-0000_Baseline_set_up branch from b7ab804 to eb543db Compare February 20, 2026 14:33
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8 Security Hotspots
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants