CCM-8366: Create proof request on send test nhs app message#965
Open
andykay-nhs wants to merge 2 commits into
Open
CCM-8366: Create proof request on send test nhs app message#965andykay-nhs wants to merge 2 commits into
andykay-nhs wants to merge 2 commits into
Conversation
andykay-nhs
force-pushed
the
feature/CCM-8366
branch
2 times, most recently
from
2db3d29 to
ade353e
Compare
andykay-nhs
force-pushed
the
feature/CCM-8366
branch
from
ade353e to
300cf93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now when a test nhs app message is successfully submitted, the server action calls POST /templates/{templateId}/proofing-request and redirects to the appropriate page utilising the returned id of the proofing request.
Also moved the send test message error summary above the page heading + additional unit test for checking the test nhs number is 10 digits as per test review comment from Lee on CCM-8354
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.