Skip to content

CCM-14149: Letter Preview Placeholder#832

Draft
jamesthompson26-nhs wants to merge 70 commits intomainfrom
feature/CCM-14149_Letter_Preview_Placeholder
Draft

CCM-14149: Letter Preview Placeholder#832
jamesthompson26-nhs wants to merge 70 commits intomainfrom
feature/CCM-14149_Letter_Preview_Placeholder

Conversation

@jamesthompson26-nhs
Copy link
Contributor

@jamesthompson26-nhs jamesthompson26-nhs commented Feb 10, 2026

Description

Builds and a new Image from a base image deployed to GHCR by notify-docker-images and publishes a bundled lambda including the code to an ECR in the acct component which is then used by terraform (using a new version of the lambda shared module) to deploy 'letter-preview-renderer'. The lambda is currently just the example-lambda pulled from the repo template.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@jamesthompson26-nhs jamesthompson26-nhs changed the title Feature/ccm 14149 letter preview placeholder CCM-14149: letter preview placeholder Feb 10, 2026
@jamesthompson26-nhs jamesthompson26-nhs changed the title CCM-14149: letter preview placeholder CCM-14149: Letter Preview Placeholder Feb 10, 2026
@jamesthompson26-nhs jamesthompson26-nhs marked this pull request as ready for review February 10, 2026 15:54
@jamesthompson26-nhs jamesthompson26-nhs requested review from a team as code owners February 10, 2026 15:54
@jamesthompson26-nhs jamesthompson26-nhs marked this pull request as draft February 10, 2026 16:59
}
},
{
rulePriority = 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add the archiving policy later, just putting a comment as discussed

@@ -0,0 +1,27 @@
module "letter_preview_renderer_lambda" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need this to be inside the backend_api module so it deploys for both app and sandbox

@@ -0,0 +1,69 @@
#!/bin/bash
Copy link
Contributor

@alexnuttall alexnuttall Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be worth making this a shareable, parameterised script like in core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants