Skip to content

added scenario where mix Disease Type has one unauthorized disease type#1254

Merged
FimranNHS merged 15 commits intomasterfrom
feature/VED-1049---updated-for-authorized-vaccinetype
Mar 2, 2026
Merged

added scenario where mix Disease Type has one unauthorized disease type#1254
FimranNHS merged 15 commits intomasterfrom
feature/VED-1049---updated-for-authorized-vaccinetype

Conversation

@FimranNHS
Copy link
Contributor

@FimranNHS FimranNHS commented Feb 27, 2026

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Contributor

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-1049

dlzhry2nhs
dlzhry2nhs previously approved these changes Feb 27, 2026
Thomas-Boyle
Thomas-Boyle previously approved these changes Feb 27, 2026
@FimranNHS FimranNHS dismissed stale reviews from Thomas-Boyle and dlzhry2nhs via 706ec2b February 27, 2026 21:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2026

And The Search Response should contain search results and OperationOutcome for invalid immunization targets

@smoke
@Delete_cleanUp @supplier_name_MAVIS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably fine for now, but because we have bound our tests to Actual rather than Fake test suppliers (e.g. Postman/Test app) in some cases, this could in future pass if we gave MAVIS permission for the unauthorized vacc type in future.

Worth consideration @FimranNHS but I will approve anyhow.

@dlzhry2nhs dlzhry2nhs temporarily deployed to internal-dev-sandbox March 2, 2026 10:34 — with GitHub Actions Inactive
@dlzhry2nhs dlzhry2nhs temporarily deployed to internal-dev-sandbox March 2, 2026 10:35 — with GitHub Actions Inactive
@FimranNHS FimranNHS merged commit 5feccaf into master Mar 2, 2026
17 checks passed
@FimranNHS FimranNHS deleted the feature/VED-1049---updated-for-authorized-vaccinetype branch March 2, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants