VED-855: Low/Info priority Sonar maintainability issues#1251
Open
JamesW1-NHS wants to merge 6 commits intomasterfrom
Open
VED-855: Low/Info priority Sonar maintainability issues#1251JamesW1-NHS wants to merge 6 commits intomasterfrom
JamesW1-NHS wants to merge 6 commits intomasterfrom
Conversation
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-855 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Cleaning the remaining 6 Info issues, all TODOs.
Sonar will not pick up TODO's as issues IF they have a ticket defined with them in the TODO line; hence we tag them with ticket numbers. Tickets have been created where appropriate. Have also removed a redundant TODO and a redundant Sonar coverage exclusion.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.