Open
Conversation
billwirz1
changed the title
Lambdas Coverage Report
|
UI Coverage Report
|
Contributor
There was a problem hiding this comment.
Pull request overview
Implements a new SessionDbClient repository in lambdas/src/lib/db/ to provide CRUD operations for the session table, including shared retry/backoff logic intended for transient Aurora/Postgres connectivity issues.
Changes:
- Added
SessionDbClientwithcreateSession,getSession,updateSession, anddeleteSession, using parameterised SQL and a whitelist-driven update builder. - Introduced
db-retryhelper (isTransientDatabaseError,executeDbOperationWithRetry) with exponential backoff + jitter defaults. - Added Jest unit tests covering the new session repository and retry helper behaviour.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lambdas/src/lib/db/session-db-client.ts | New session table CRUD client; wraps DB operations with retry and maps DB rows to the shared ISession model. |
| lambdas/src/lib/db/session-db-client.test.ts | Unit tests for session CRUD behaviour and retry on transient failures. |
| lambdas/src/lib/db/db-retry.ts | New generic retry/backoff utility for DB operations with transient error classification. |
| lambdas/src/lib/db/db-retry.test.ts | Unit tests verifying retry logic timing and transient error detection. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements a new SessionDbClient repository in lambdas/src/lib/db/ to provide CRUD operations for the session table, including shared retry/backoff logic intended for transient Aurora/Postgres connectivity issues.
Changes:
Added SessionDbClient with createSession, getSession, updateSession, and deleteSession, using parameterised SQL and a whitelist-driven update builder.
Introduced db-retry helper (isTransientDatabaseError, executeDbOperationWithRetry) with exponential backoff + jitter defaults.
Added Jest unit tests covering the new session repository and retry helper behaviour.
Context
Description:
Implement a CRUD wrapper for interacting with the session table. Use existing standards and practice.
Acceptance Criteria:
createSession(session)
getSession(sessionId)
updateSession(sessionId, updates)
deleteSession(sessionId)
Includes retry/backoff + Aurora connection best practices.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.