[HOTE-1125] feat: create order_status_reminder table#343
Open
iichr wants to merge 5 commits intoNHSDigital:mainfrom
Open
[HOTE-1125] feat: create order_status_reminder table#343iichr wants to merge 5 commits intoNHSDigital:mainfrom
iichr wants to merge 5 commits intoNHSDigital:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds database support for tracking order-status-triggered reminders by introducing new reminder status types and an order_status_reminder table, plus local seed/sample data and schema diagram updates.
Changes:
- Add
reminder_status_typeandorder_status_remindertables (with constraints and indexes). - Seed initial
reminder_status_typevalues via migration. - Add a sample
order_status_reminderseed row and update the PlantUML schema diagram.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| database/schema_diagram.puml | Documents the new reminder tables and relationships in the schema diagram. |
| database/migrations/000008_add_order_status_reminder_table.sql | Creates reminder tables, inserts initial reminder statuses, and adds indexes. |
| database/03-seed-hometest-data.sql | Adds a sample order_status_reminder row to local seed data. |
lewisbirks
reviewed
Apr 13, 2026
Contributor
lewisbirks
left a comment
There was a problem hiding this comment.
Couple of comments, don't forget that a similar change will be required in the terraform repo. Maybe your next ticket can be to resolve that 😅
715c224 to
8fa9cf9
Compare
lewisbirks
approved these changes
Apr 13, 2026
cc5fcf0 to
7063930
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tested locally with the db and a seeded entry.
Migration also created in NHSDigital/hometest-mgmt-terraform#96
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.