Skip to content

[HOTE-1125] feat: create order_status_reminder table#343

Open
iichr wants to merge 5 commits intoNHSDigital:mainfrom
iichr:feature/hote-1125/order-status-reminder-table
Open

[HOTE-1125] feat: create order_status_reminder table#343
iichr wants to merge 5 commits intoNHSDigital:mainfrom
iichr:feature/hote-1125/order-status-reminder-table

Conversation

@iichr
Copy link
Copy Markdown

@iichr iichr commented Apr 13, 2026

Description

  • creates a database table for the order status reminder, using the schema in the Status Updates Triggering Notifications document.
  • adds required indexes for searching

tested locally with the db and a seeded entry.

Migration also created in NHSDigital/hometest-mgmt-terraform#96

Context

  • enabler for the tracking and storing of reminders

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Copilot AI review requested due to automatic review settings April 13, 2026 10:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds database support for tracking order-status-triggered reminders by introducing new reminder status types and an order_status_reminder table, plus local seed/sample data and schema diagram updates.

Changes:

  • Add reminder_status_type and order_status_reminder tables (with constraints and indexes).
  • Seed initial reminder_status_type values via migration.
  • Add a sample order_status_reminder seed row and update the PlantUML schema diagram.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
database/schema_diagram.puml Documents the new reminder tables and relationships in the schema diagram.
database/migrations/000008_add_order_status_reminder_table.sql Creates reminder tables, inserts initial reminder statuses, and adds indexes.
database/03-seed-hometest-data.sql Adds a sample order_status_reminder row to local seed data.

Copy link
Copy Markdown
Contributor

@lewisbirks lewisbirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, don't forget that a similar change will be required in the terraform repo. Maybe your next ticket can be to resolve that 😅

Copilot AI review requested due to automatic review settings April 13, 2026 11:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings April 13, 2026 12:15
@iichr iichr force-pushed the feature/hote-1125/order-status-reminder-table branch from 715c224 to 8fa9cf9 Compare April 13, 2026 12:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

@iichr iichr changed the title [HOTE-1125] feat: create order_status_reminder table and seed sample data [HOTE-1125] feat: create order_status_reminder table Apr 13, 2026
@iichr iichr force-pushed the feature/hote-1125/order-status-reminder-table branch from cc5fcf0 to 7063930 Compare April 14, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants