Conversation
…into feature/hote-840/Enable-Network-firewall
There was a problem hiding this comment.
Pull request overview
This PR currently removes environment-specific Terragrunt overrides for the dev/hometest-app/staging deployment (notably the custom domain/certificate overrides and the “hello-world” lambda override). As submitted, the changes don’t align with the stated goal of adding network firewall rules.
Changes:
- Removed the staging environment’s “hello-world” lambda override from
terragrunt.hcl. - Deleted
domain.hcl, which previously overrode staging domains and enabled per-environment certificates.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| infrastructure/environments/dev/hometest-app/staging/terragrunt.hcl | Removes the staging-specific lambda override; leaves an empty inputs map. |
| infrastructure/environments/dev/hometest-app/staging/domain.hcl | Deletes domain/certificate overrides that app.hcl uses to configure env/api domains and cert creation. |
Comments suppressed due to low confidence (1)
infrastructure/environments/dev/hometest-app/staging/domain.hcl:1
- domain.hcl is read by infrastructure/environments/_envcommon/app.hcl to override env_domain/api_domain and to enable per-environment ACM certificates. Removing this file will revert staging to the default domain pattern (and disable create_cloudfront_certificate/create_api_certificate). If you still need staging.hometest.service.nhs.uk / api.staging.hometest.service.nhs.uk with dedicated certs, keep this file (or migrate these settings to the new location/mechanism).
| inputs = { | ||
| # Hello World Lambda - simple health check (dev environment only) | ||
| lambdas = { | ||
| "hello-world-lambda" = { | ||
| description = "Hello World Lambda - Health Check" | ||
| api_path_prefix = "hello-world" | ||
| handler = "index.handler" | ||
| timeout = 30 | ||
| memory_size = 256 | ||
| environment = { | ||
| NODE_OPTIONS = "--enable-source-maps" | ||
| ENVIRONMENT = basename(get_terragrunt_dir()) | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This PR removes domain.hcl and the hello-world lambda override, but the PR title/description indicate “Add network firewall rules”. Either update the PR metadata to match what’s actually changing here, or include the missing network firewall rule changes so reviewers can assess the full intended impact.
| inputs = { | ||
| # Hello World Lambda - simple health check (dev environment only) | ||
| lambdas = { | ||
| "hello-world-lambda" = { | ||
| description = "Hello World Lambda - Health Check" | ||
| api_path_prefix = "hello-world" | ||
| handler = "index.handler" | ||
| timeout = 30 | ||
| memory_size = 256 | ||
| environment = { | ||
| NODE_OPTIONS = "--enable-source-maps" | ||
| ENVIRONMENT = basename(get_terragrunt_dir()) | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
inputs is now an empty map. If this environment no longer has any overrides, consider removing the inputs block entirely to reduce noise.
Also, this file’s header comments currently point to “./domain.hcl” and describe this as the “dev” environment, but domain.hcl is deleted in this PR and env.hcl sets environment="staging"; please update the comments (or restore domain.hcl) so the configuration is self-consistent.
…hanges and ensuring create_before_destroy
|
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.