Skip to content

PPHA-685: Pen testing hardening changes#310

Merged
mrlockstar merged 1 commit into
mainfrom
PPHA-685-PENTEST-Storage-account-hardening
Jun 1, 2026
Merged

PPHA-685: Pen testing hardening changes#310
mrlockstar merged 1 commit into
mainfrom
PPHA-685-PENTEST-Storage-account-hardening

Conversation

@mrlockstar
Copy link
Copy Markdown
Contributor

@mrlockstar mrlockstar commented Jun 1, 2026

Description

Added allow_nested_items_to_be_public, this allows nested that are contained inside the blob storage to become public if enabled, please note, this ONLY works if the storage account is public.

Also improve the description for variable "shared_access_key_enabled" as disabling this feature requires config changes in the root module.

https://dev.azure.com/nhse-dtos/lung-cancer-screening/_build/results?buildId=39378&view=results

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@mrlockstar mrlockstar force-pushed the PPHA-685-PENTEST-Storage-account-hardening branch from 3bbcfa2 to 855680b Compare June 1, 2026 13:47
@mrlockstar mrlockstar added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit 96c3d92 Jun 1, 2026
11 checks passed
@mrlockstar mrlockstar deleted the PPHA-685-PENTEST-Storage-account-hardening branch June 1, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants