Skip to content

chore: Fixing some low priority sonarqube issues#1668

Merged
MWClayson-NHS merged 15 commits intomainfrom
chore-fix-low-sonarqube-issues
Apr 16, 2026
Merged

chore: Fixing some low priority sonarqube issues#1668
MWClayson-NHS merged 15 commits intomainfrom
chore-fix-low-sonarqube-issues

Conversation

@Joseph2910
Copy link
Copy Markdown
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 18, 2025

Unit Test Results

✔️ Tests 1019 / 1019 - passed in 71.8s
📝 Coverage 47.34%
📏 4823 / 10490 lines covered 🌿 1183 / 2198 branches covered
🔍 click here for more details

✏️ updated for commit 196b2a6

@Joseph2910 Joseph2910 marked this pull request as ready for review September 23, 2025 14:58
Comment thread application/CohortManager/src/Web/app/data/mockDataStore.ts
Comment thread application/CohortManager/src/Web/jest.config.ts
Comment thread scripts/backups/db-restore-container/Dockerfile Outdated
@sonarqubecloud
Copy link
Copy Markdown

@stephhou stephhou added the Stale PR A Pull Request that has been open for more than 30 days label Feb 6, 2026
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
9 pipeline(s) were filtered out due to trigger conditions.

Copy link
Copy Markdown
Contributor

@MWClayson-NHS MWClayson-NHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged safely

@sonarqubecloud
Copy link
Copy Markdown

@MWClayson-NHS MWClayson-NHS added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit 634023e Apr 16, 2026
58 checks passed
@MWClayson-NHS MWClayson-NHS deleted the chore-fix-low-sonarqube-issues branch April 16, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale PR A Pull Request that has been open for more than 30 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants