Skip to content

Update NHSDigital-Practitioner #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KazeemHamzat wants to merge 4 commits into
base: nhsdigital_main
Choose a base branch
from
Open

Update NHSDigital-Practitioner #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e571883
Update NHSDigital-Practitioner
KazeemHamzat Jun 1, 2026
5b4fd40
Testing Examples
KazeemHamzat Jun 1, 2026
94e40ef
Update NHSDigital-Practitioner
KazeemHamzat Jun 2, 2026
1ef6a3a
Removing GMC constraint
KazeemHamzat Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions Practitioner/Practitioner-DrLucyHale-Example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
{
"resourceType": "Practitioner",
"id": "Practitioner-DrLucyHale-Example",
"identifier": [
{
"use": "official",
"system": "https://fhir.hl7.org.uk/Id/gmc-number",
"value": "L9999999"
}
],
"name": [
{
"use": "official",
"text": "Lucy Hale",
"family": "Hale",
"given": [
"Lucy"
]
}
],
"qualification": [
{
"code": {
"coding": [
{
"system": "http://terminology.hl7.org/CodeSystem/v2-0360",
"code": "MD",
"display": "Doctor of Medicine"
}
]
}
}
]
}
2 changes: 1 addition & 1 deletion Practitioner/Practitioner-validation-example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"resourceType": "Practitioner",
"id": "e7c2d218-f55c-4855-afd8-9134468b19db",
"id": "Practitioner-Validation-Example",
"identifier": [
{
"system": "https://fhir.nhs.uk/Id/sds-user-id",
Expand Down
7 changes: 0 additions & 7 deletions StructureDefinition/NHSDigital-Practitioner.StructureDefinition.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,6 @@
<expression value="identifier.where(system='https://fhir.hl7.org.uk/Id/gmp-number').exists().not() or (identifier.where(system='https://fhir.hl7.org.uk/Id/gmp-number').exists() and identifier.where(system='https://fhir.hl7.org.uk/Id/gmp-number').value.matches('^[G]{1}[01234589]{1}[0-9]{6}$'))" />
<source value="https://fhir.nhs.uk/StructureDefinition/NHSDigital-Practitioner" />
</constraint>
<constraint>
<key value="prac-gmc" />
<severity value="warning" />
<human value="GMC must be of the format CNNNNNNN" />
<expression value="identifier.where(system='https://fhir.hl7.org.uk/Id/gmc-number').exists().not() or (identifier.where(system='https://fhir.hl7.org.uk/Id/gmc-number').exists() and identifier.where(system='https://fhir.hl7.org.uk/Id/gmc-number').value.matches('^[C]{1}[0-9]{7}$'))" />
Copy link
Copy Markdown
Contributor

@ryma2fhir ryma2fhir Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to find the official format for GMC numbers but I've not been successful.

I think all we can say is that it will be a 7 or 8 alphanumerical value, but without proof I this is just an assumption which may be incorrect or change.

I'm in favour of removing the check and expecting Programmes to ensure the gmc number is correct.

For info:

It's a 7 number code: https://www.gmc-uk.org/registration-and-licensing/employers-and-other-organisations/doctors-employers-royal-colleges-and-medical-schools/employing-a-doctor/gmc-reference-numbers

although these state it can be L+6 digit https://cmbregistration.uk/regnumber/

This states it Could be 7 num digits, L+6, or D+6 https://publichealthscotland.scot/resources-and-tools/health-intelligence-and-data-management/national-data-catalogue/data-dictionary/search-the-data-dictionary/general-medical-council-number-of-referring-doctordentistnurseallied-healthcare-professional/

C+7 https://v2.datadictionary.nhs.uk/data_dictionary/data_field_notes/c/ce/consultant_code_de.asp@shownav=1.html

PAs will have an alphabetical prefix https://pa-per.co.uk/pas-to-get-prefix-on-gmc-registration-number-but-no-change-to-proposed-professional-title

Copy link
Copy Markdown
Contributor Author

@KazeemHamzat KazeemHamzat Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Comment from Rob Gooch in the request email: 'This needs amended to also allow a GMC without a prefix of C. A valid GMC code is NNNNNNN. It is only in the hospital care setting where there has been a historic requirement to prefix with a “C”.
  2. From the links you provided, 1 and 4 are government/GMC websites in England, which align with the format NNNNNNN or CNNNNNNN. completely removing the constraint to accept wider range of inputs is likely to reduce data quality. Thus, I will say sticking with these two formats is a better option at this time.

Copy link
Copy Markdown
Contributor

@ryma2fhir ryma2fhir Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Once regulation begins and PAs and AAs gain registration with us, they will receive a seven-digit GMC reference number with a short alphabetical prefix" https://www.pulsetoday.co.uk/news/workforce/pas-to-get-distinguishing-gmc-number-but-no-title-change/

We should not be restricting this resource with no use-case. It should be open to all of our customers to be interoperable.

Copy link
Copy Markdown
Contributor Author

@KazeemHamzat KazeemHamzat Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constraint remove from gmc-reference number.

<source value="https://fhir.nhs.uk/StructureDefinition/NHSDigital-Practitioner" />
</constraint>
<constraint>
<key value="prac-gphc" />
<severity value="warning" />
Expand Down