fix: update miniconda3 version and improve nodejs installation proces… - #145
Merged
Merged
Conversation
hamed-musallam
approved these changes
Sep 25, 2026
Collaborator
|
I updated the conda channels configuration. Now we are using |
hamed-musallam
requested
a lite review from Copilot
and removed request for
Copilot
September 25, 2026 18:45
NishaSharma14
added a commit
that referenced
this pull request
Sep 29, 2026
* feat: add include/exclude file filters to parse-spectra (#138) * feat(nmr-cli): update NMRium core packages to v2.6.0 * chore(nmr-cli): update dependencies * feat(nmr-cli): add include/exclude file filters to parse-spectra * feat(API): add include/exclude file filters to spectra parse endpoints * feat(nmr-cli): update NMRium core packages to v2.7.0 * refactor: parallelize parse spectra pipeline across concurrent worker/browser lanes (#141) Replace the single-threaded, one-browser-per-spectrum flow with a fixed number of concurrent lanes, each owning a persistent worker thread (CPU processing/detection) and, when snapshots are enabled, a persistent browser page: - run-pipeline.ts / run-concurrency.ts: drive parse -> process -> detect -> snapshot across N lanes instead of one spectrum at a time. - spectrum-worker.ts / worker-entry.ts: offload processing, detection, and serialization to worker threads so CPU work no longer blocks the main thread. - browser-manager.ts: reuse one browser/context per lane across every spectrum it handles, instead of relaunching per spectrum. - prase-spectra.ts: delegate to the new pipeline; stream output via outputResult instead of buffering the full result in memory. * Revert "refactor: parallelize parse spectra pipeline across concurrent worker…" (#142) This reverts commit 1c39986. * feat(nmr-cli): add nmr-correlation as a new command (#140) * feat: expose nmr-correlation package as a new nmr-cli command * Address review: support local directory input, filter for FT spectra, add real yargs defaults/aliases * Address round 2 review: explicit if/else branching, clarify spectrum filter rationale * Address review: filter correlation spectra by ranges/zones instead of reference equality * Address review: extract readSpectra and filterSpectra helper functions * chore: upgrade actions and dependencies in workflow files to latest versions * fix: update miniconda3 version and improve nodejs installation proces… (#145) * fix: update miniconda3 version and improve nodejs installation process in Dockerfile * fix: use conda-forge as the only conda channel --------- Co-authored-by: hamed musallam <hamed.musallam@gmail.com> * fix: correct GitHub contributors badge link and minor text adjustments in README --------- Co-authored-by: hamed-musallam <35760236+hamed-musallam@users.noreply.github.com> Co-authored-by: abeer.dev <56149548+MuhammadAbeerAkmal@users.noreply.github.com> Co-authored-by: hamed musallam <hamed.musallam@gmail.com>
hamed-musallam
added a commit
that referenced
this pull request
Oct 2, 2026
#145) * fix: update miniconda3 version and improve nodejs installation process in Dockerfile * fix: use conda-forge as the only conda channel --------- Co-authored-by: hamed musallam <hamed.musallam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s in Dockerfile