Skip to content

revert(runner): remove in-session payment session reporting - #4

Merged
eliteprox merged 1 commit into
releases/finalfrom
ja/revert-call-runner-manifest-id
Oct 20, 2026
Merged

eliteprox merged 1 commit into
releases/finalfrom
ja/revert-call-runner-manifest-id

Conversation

@eliteprox

Copy link
Copy Markdown

Summary

This PR removes the payment-session reporting that #1 merged into releases/final. call_runner no longer takes on_payment_session, and LivePaymentSession no longer carries a private _on_payment hook or a manifest_id property. The tree matches fc47903, the parent of that merge.

PR #3 is stacked on this branch and puts the callback back on call_runner.

Why

#1 reported each signed session from inside LivePaymentSession. The replacement keeps that reporting, but the callback belongs on call_runner, next to the paid request. Reverting first makes that replacement reviewable on its own. Reviewing both in one diff hides the new callback under the deleted one.

What callers see

  • call_runner. No on_payment_session argument. A 402 is still paid, and the paid request still sends Livepeer-Payment and Livepeer-Segment.
  • LivePaymentSession. No manifest_id property and no _on_payment constructor argument. get_payment() returns the signer response and does not invoke a callback.
  • Exports. LivePaymentSessionCallback is no longer exported.

Known limits

Test plan

  • git diff fc47903 4f8319c is empty. This is git revert -m 1 13edf39 and does not add code beyond that revert.
  • uv run pytest on the stacked branch ja/payment-callback, which contains this revert, at 391f37e: 239 passed. Later commits on that branch only rename the callback type.

…nifest-id"

This reverts commit 13edf39, reversing
changes made to fc47903.
@sonarqubecloud

Copy link
Copy Markdown

@eliteprox
eliteprox merged commit 60aed2e into releases/final Oct 20, 2026
2 checks passed

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

No bugs, security issues, or incomplete revert. git diff fc47903 4f8319c is empty, and the five-file diff is the exact inverse of merge 13edf39 (payment-session reporting only). Nothing else from that merge is dropped.

Checked:

  • on_payment_session, LivePaymentSessionCallback, LivePaymentSession.manifest_id, and _on_payment are gone from the package, call_runner overloads, and tests. No leftover references in Python or docs.
  • _get_runner_payment still signs, then rejects an empty payment or segCreds before Livepeer-Payment / Livepeer-Segment are set. SignerRefreshRequired still clears the challenge and retries.
  • Paid-call coverage that predates the callback remains (test_paid_call_retries_with_payment_headers, fixed-price retry, refresh bounds). The deleted tests only covered the removed callback.

Merge note (not a defect in this diff): releases/final at this commit does not report a signed session. Callers of the #1 API (on_payment_session, session.manifest_id) will break if they move onto this head before #3. The PR already keeps livepeer-builder-core on e6d243b, which is the right pin until that follow-up lands.

Open in Web View Automation 

Sent by Cursor Automation: build-track code reviews

@eliteprox
eliteprox deleted the ja/revert-call-runner-manifest-id branch October 21, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant