Repository navigation
revert(runner): remove in-session payment session reporting - #4
Conversation
|
There was a problem hiding this comment.
Review
No bugs, security issues, or incomplete revert. git diff fc47903 4f8319c is empty, and the five-file diff is the exact inverse of merge 13edf39 (payment-session reporting only). Nothing else from that merge is dropped.
Checked:
on_payment_session,LivePaymentSessionCallback,LivePaymentSession.manifest_id, and_on_paymentare gone from the package,call_runneroverloads, and tests. No leftover references in Python or docs._get_runner_paymentstill signs, then rejects an emptypaymentorsegCredsbeforeLivepeer-Payment/Livepeer-Segmentare set.SignerRefreshRequiredstill clears the challenge and retries.- Paid-call coverage that predates the callback remains (
test_paid_call_retries_with_payment_headers, fixed-price retry, refresh bounds). The deleted tests only covered the removed callback.
Merge note (not a defect in this diff): releases/final at this commit does not report a signed session. Callers of the #1 API (on_payment_session, session.manifest_id) will break if they move onto this head before #3. The PR already keeps livepeer-builder-core on e6d243b, which is the right pin until that follow-up lands.
Sent by Cursor Automation: build-track code reviews





Summary
This PR removes the payment-session reporting that #1 merged into
releases/final.call_runnerno longer takeson_payment_session, andLivePaymentSessionno longer carries a private_on_paymenthook or amanifest_idproperty. The tree matchesfc47903, the parent of that merge.PR #3 is stacked on this branch and puts the callback back on
call_runner.Why
#1 reported each signed session from inside
LivePaymentSession. The replacement keeps that reporting, but the callback belongs oncall_runner, next to the paid request. Reverting first makes that replacement reviewable on its own. Reviewing both in one diff hides the new callback under the deleted one.What callers see
call_runner. Noon_payment_sessionargument. A 402 is still paid, and the paid request still sendsLivepeer-PaymentandLivepeer-Segment.LivePaymentSession. Nomanifest_idproperty and no_on_paymentconstructor argument.get_payment()returns the signer response and does not invoke a callback.LivePaymentSessionCallbackis no longer exported.Known limits
releases/finalreports a manifest id until feat(runner): report each signed payment session from call_runner #3 lands on top of this branch. livepeer-builder-core still pinse6d243b, which is the pre-revert implementation, so this PR does not change that pin.Test plan
git diff fc47903 4f8319cis empty. This isgit revert -m 1 13edf39and does not add code beyond that revert.uv run pyteston the stacked branchja/payment-callback, which contains this revert, at391f37e: 239 passed. Later commits on that branch only rename the callback type.