fix(bin): graceful shutdown + deploy docs (TLS, tunnel verdict) - #19
Merged
Merged
Conversation
Short-lived CLI commands dropped the iroh endpoint without close(), so iroh logged "Endpoint dropped without calling Endpoint::close" on every rds id/ticket. The agent and both server binaries had no SIGTERM handling at all: systemctl stop killed them mid-accept, peers saw an abrupt socket death instead of CONNECTION_CLOSE, and relayed websockets got a silent RST. - rds-cli: endpoint.close() before exit. - rds-agent: select accept loop vs SIGINT/SIGTERM, then close the endpoint so peers get CONNECTION_CLOSE. - rds-server/rds-relay: same signal handling, then iroh_relay::Server::shutdown() to close listener + client sockets.
- Document the nginx/haproxy TLS-terminator option in front of 3340 and why plaintext HTTP relaying is already safe (E2E payloads, EndpointId admission). - Record the Cloudflare Tunnel/WARP verdict: directory could be tunnel-fronted, relay probably but edge reconnects drop attached endpoints, and no tunnel carries endpoint QUIC/UDP. VPS preferred. - Fix stale Documentation= URL (rldyourmnd -> NDDev-OpenNetwork).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
endpoint.close()on exit —rds id/ticketno longer log iroh's "ungraceful abort" error.iroh_relay::Server::shutdown()(clean listener+websocket teardown undersystemctl stop).Documentation=URLs fixed.Test plan
cargo build --locked --workspace --all-targetstransport-noq,owned-relaylanes cleanrds-agent/rds-cli/rds-relay/rds-servertests greenrds idsmoke: zero ERROR lines (previously logged ungraceful drop)Generated with Devin