Skip to content

fix(release): compare version components as bounded integers #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rldyourmnd merged 1 commit into from
Sep 19, 2026
Merged

fix(release): compare version components as bounded integers #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/release-bundle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
mapfile -t tags < <(
gh api "repos/$GITHUB_REPOSITORY/tags?per_page=100" --paginate --jq '.[].name' \
| grep -x 'gds-v[0-9]*\.[0-9]*\.[0-9]*' \
| sort -t. -k1.6nr -k2nr -k3nr
| sort -t. -k1.6,1nr -k2,2nr -k3,3nr
)
if [ "${#tags[@]}" -eq 0 ]; then
echo "No gds-v* tag exists; the first automatic release requires one published baseline" >&2
Expand Down Expand Up @@ -90,9 +90,17 @@ jobs:
next_version="$(awk -F. -v v="$previous_version" 'BEGIN{split(v,p,"."); printf "%d.%d.%d", p[1], p[2], p[3]+1}')"
fi
# Monotonicity is structural, not assumed: the new identity must be
# strictly greater than the release it follows.
highest="$(printf '%s\n' "$previous_version" "$next_version" | sort -t. -k1n -k2n -k3n | tail -1)"
if [ "$highest" != "$next_version" ] || [ "$next_version" = "$previous_version" ]; then
# strictly greater than the release it follows. Compare components
# numerically -- sort -n reads "9.10" as the float 9.1, which orders
# a double-digit patch below its predecessor.
if ! awk -F. -v a="$previous_version" -v b="$next_version" 'BEGIN{
split(a, x, "."); split(b, y, ".");
for (i = 1; i <= 3; i++) {
if (y[i] + 0 > x[i] + 0) exit 0;
if (y[i] + 0 < x[i] + 0) exit 1;
}
exit 1
}'; then
echo "next version $next_version is not greater than $previous_version" >&2
exit 1
fi
Expand Down
Loading