fix(release): bind attestations to the workflow trigger ref - #180
Merged
Merged
Conversation
The automatic pipeline creates the release tag inside the same run that builds the artifact, so GitHub provenance binds the push trigger ref (refs/heads/main), not the tag. The envelope now records both refs: source_ref stays the exact release boundary and trigger_ref carries the ref the signer actually recorded. The expected attestation identity digest and all verifiers use trigger_ref when present and fall back to source_ref for legacy envelopes. Also drops the harness-evidence archive extraction flags left over from the removed evidence-input flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refs/heads/main), notrefs/tags/gds-v*. Offline verification rejected gds-v0.9.8 for exactly that mismatch.source_refstays the exact release boundary;trigger_refcarries the ref the signer actually records. The expected attestation identity digest and every verifier (bundle, release directory, consumer install) usetrigger_refwhen present and fall back tosource_reffor legacy envelopes.--trigger-ref "$GITHUB_REF"; failure envelopes record both refs as well.--extract-harness-evidence-*flags and their archive reader — evidence stopped being a release-builder input when channels were removed.trigger_ref(sourceRef shape) on release and release-failure envelopes.Verification
scripts/validate_shell.shPASS (shellcheck 0.11.0, 8 scripts)scripts/validate_go_core.sh --quickPASS (tidy, vet, tests)go test ./...PASS (all packages)python3 -m pytest70/70 (pinned env)scripts/validate_release.shPASS including integrated assurance on the committed treetrigger_refverify viasource_refunchanged;allowed_channelsremains in the trust policy for legacy artifacts.Generated with Devin