Fix to handle recent netcdf4-python iterator changes #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erogluorhan
approved these changes
Oct 29, 2025
Collaborator
erogluorhan
left a comment
erogluorhan
left a comment
There was a problem hiding this comment.
This makes sense for the time being. Thanks for taking care of it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest release netcdf4-python added an
__iter__method that raises a not implemented error toDatasetobjects. Unfortunately this makes them look like anIterablechanging some behavior in wrf-python and ultimately resulting in an error.This is a bit of a clunky fix, but it should do the trick.
Closes #290