Skip to content

Add correlation to BSL-docs - #51

Merged
BrianSipos merged 3 commits into
mainfrom
add-correlation-BSL-docs
Sep 24, 2026
Merged

BrianSipos merged 3 commits into
mainfrom
add-correlation-BSL-docs

Conversation

@jeronstone

@jeronstone jeronstone commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

This is documentation for NASA-AMMOS/BSL#334 and NASA-AMMOS/BSL#340.

@jeronstone
jeronstone requested a review from a team as a code owner September 18, 2026 19:42
@jeronstone jeronstone self-assigned this Sep 18, 2026
@jeronstone jeronstone added this to the BSL v2.0.0 milestone Sep 18, 2026
@jeronstone jeronstone added the documentation Improvements or additions to documentation label Sep 18, 2026
@jeronstone jeronstone added this to BSL Sep 18, 2026
@github-project-automation github-project-automation Bot moved this to Todo in BSL Sep 18, 2026

@BrianSipos BrianSipos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definitions of correlation don't explain how they relate to role. Are they valid only on source role? What happens if a correlation is given for rules of other roles? This may need a patch on the library if the property is forbidden for other roles.

Comment thread user-guide/manual.adoc Outdated
@jeronstone

jeronstone commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor Author

The definitions of correlation don't explain how they relate to role. Are they valid only on source role? What happens if a correlation is given for rules of other roles? This may need a patch on the library if the property is forbidden for other roles.

This is a good consideration.

In BSL, if correlation is set in the SecOp for verif/accept, it should have no affect at the moment. So, it's not necessarily "bad" if correlation is set for those roles, but I agree we should specify here that it is for source role.

I think for now we can patch the policy parser to warn that correlation on non-source roles will do nothing.

Co-authored-by: Brian Sipos <brian.sipos@jhuapl.edu>
@BrianSipos BrianSipos moved this from Todo to In Progress in BSL Sep 21, 2026

@BrianSipos BrianSipos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for clarity of use.

Comment thread user-guide/manual.adoc Outdated
Co-authored-by: Brian Sipos <brian.sipos@jhuapl.edu>
@sonarqubecloud

Copy link
Copy Markdown

@BrianSipos
BrianSipos merged commit fdc5f0d into main Sep 24, 2026
7 checks passed
@BrianSipos
BrianSipos deleted the add-correlation-BSL-docs branch September 24, 2026 13:05
@github-project-automation github-project-automation Bot moved this from In Progress to Done in BSL Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants