Open
Conversation
The bootstrap theme was not changing to dark mode, resulting in various visual glitches (the font of the buttons to go to the next/prev page, background of the alerts, and probably more).
reduce border thickness and round the corners, give them a background color (using the bootstrap default colors), remove the monospaced font
Move text to i18n, update style slightly, remove the need for the mod argument to use the name of the linked page instead.
mainly makes it stand out a little more against the text. Light background with border, more padding, bigger title/caption. Ability to add an optional description added too
align with previous changes to the docstatus shortcode
If dark theme is preferred, also initialize bootstrap theme as dark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights:
carouselshortcode, updated the CAN-AM page to use this element.feature-guide,docstatus, andcompatibility-keycompatibility-keyshortcode to include the definitions for the intersection types (and updated all tech specs pages to use this updated component)menu-iconstyle. Stands out more against regular paragraph text. Preparing this for future updates - would like to automatically extract the icons and descriptions directly from the NAM dbpf files and have them looked up via the icon name. Much more sustainable long-term.alertanddocstatusstyle. With these shortcodes that derive from bootstrapalertstyles, use the included bootstrap colors instead of hardcoded hex colors. Looks better in both light and dark mode.feature-guidestyle. Name of page is also automatically pulled from the linked article.