Add stop action and switch/add playback modes to scene-controller#18
Open
mutec wants to merge 2 commits into
Open
Add stop action and switch/add playback modes to scene-controller#18mutec wants to merge 2 commits into
mutec wants to merge 2 commits into
Conversation
The scene-controller now supports a fourth action, stop, which halts output for a scene while keeping it stored; an optional node setting emits a nulled universe once when the last active scene stops. A new playback mode setting controls whether play switches the running look or stacks scenes additively (HTP, highest value wins). In add mode stop and reset of one scene re-emit the remaining combined look and only darken the output once the last scene ends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the scene-controller with a fourth action and two new node settings.
New action:
stopreset, which deletes).New setting: Playback mode
playreplaces the running look.stop/resetof one scene re-emits the remaining combined look; the output only goes dark once the last scene ends.The controller emits DMX values once per change; the downstream sACN-out node keeps streaming them.
Behaviour notes
resetis unchanged: it deletes the scene and blacks it out if currently playing.stopblackout messages carrystopped: true(analogous toreset: true).Verification
npm run build(tsc + build.js), eslint and prettier all clean;dist/rebuilt.