Translate palette labels and fallback names via the message catalog#17
Open
mutec wants to merge 2 commits into
Open
Translate palette labels and fallback names via the message catalog#17mutec wants to merge 2 commits into
mutec wants to merge 2 commits into
Conversation
Route each node's paletteLabel and the empty-name fallback label through
this._() so they resolve from the i18n catalog instead of hard-coded
strings. Add paletteLabel and label.fallback keys (en-US + de) per node;
the universe fallback interpolates via {{universe}}.
Node-RED configures i18next with __var__ interpolation delimiters, not
the i18next default {{var}}. The universe placeholder in the sacn-in and
sacn-out fallback labels therefore rendered literally instead of being
substituted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was & Warum
Palette-Labels und die Fallback-Namen (angezeigt, solange kein
namegesetzt ist) waren fest verdrahtet. Sie laufen jetzt über den i18n-Katalog und sind damit übersetzbar.Änderungen
init.ts(alle 3 Nodes):paletteLabelundlabelals Funktionen, diethis._("<node>.paletteLabel")bzw.this._("<node>.label.fallback", { universe })aufrufen. Beidethis-Kontexte sind alsNodeInstancetypisiert,_istI18nTFunction→ sauber typisiert, keinno-unsafe.de+en-US, pro Node): neue KeyspaletteLabelundlabel.fallback; der Universum-Fallback interpoliert via i18next-{{universe}}.Verifiziert
npm run build,eslint .(strengeno-unsafe-*),tsc --noEmitundprettier --checklaufen alle sauber; generiertes HTML + Kataloge geprüft.🤖 Generated with Claude Code