Skip to content

Removes curvature tolerance from solver setup#115

Merged
jmartfrut merged 1 commit intomainfrom
cuvature_stopcrit
Feb 10, 2026
Merged

Removes curvature tolerance from solver setup#115
jmartfrut merged 1 commit intomainfrom
cuvature_stopcrit

Conversation

@jmartfrut
Copy link
Collaborator

Removes the curvature tolerance (cuvtol) from the Newton_RaphsonSolver constructor and SolverTolerances struct. This value is not needed on construction.

Also hardcodes the curvature stopping criterion to 1e-5, which was the default, as a temporary measure to restore functionality.

Removes the curvature tolerance (`cuvtol`) from the `Newton_RaphsonSolver` constructor and `SolverTolerances` struct.
This value is not needed on construction.

Also hardcodes the curvature stopping criterion to 1e-5, which was the default, as a temporary measure to restore functionality.
@jmartfrut jmartfrut merged commit 84359a2 into main Feb 10, 2026
3 checks passed
@github-actions
Copy link

Benchmark Results (Julia v1)

Time benchmarks
main 730cb0a... main / 730cb0a...
Constitutive models/Visco-elastic Ψ 0.0487 ± 0.027 ms 0.0489 ± 0.027 ms 0.996 ± 0.78
Constitutive models/Visco-elastic ∂Ψu 0.0642 ± 0.0036 ms 0.0639 ± 0.0039 ms 1.01 ± 0.084
Constitutive models/Visco-elastic ∂Ψuu 0.112 ± 0.014 ms 0.112 ± 0.014 ms 1 ± 0.17
Simulations/StaticMechanicalDirichlet 0.133 ± 0.0068 s 0.132 ± 0.0078 s 1.01 ± 0.078
Simulations/StaticMechanicalNeumann 0.128 ± 0.012 s 0.129 ± 0.013 s 0.994 ± 0.13
Simulations/ViscoElastic 20.5 s 20.3 s 1.01
Tensor algebra/Cofactor 0.07 ± 0.01 μs 0.07 ± 0.01 μs 1 ± 0.2
Tensor algebra/Det(A)Inv(A') 0.13 ± 0.001 μs 0.131 ± 0.011 μs 0.992 ± 0.084
Tensor algebra/δδ_λ_2d 30 ± 0 ns 30 ± 0 ns 1 ± 0
Tensor algebra/δδ_μ_2d 30 ± 0 ns 30 ± 0 ns 1 ± 0
time_to_load 2.33 ± 0.0058 s 2.34 ± 0.0091 s 0.996 ± 0.0046
Memory benchmarks
main 730cb0a... main / 730cb0a...
Constitutive models/Visco-elastic Ψ 1.24 k allocs: 0.0777 MB 1.24 k allocs: 0.0777 MB 1
Constitutive models/Visco-elastic ∂Ψu 1.36 k allocs: 0.0898 MB 1.36 k allocs: 0.0898 MB 1
Constitutive models/Visco-elastic ∂Ψuu 2.32 k allocs: 0.155 MB 2.32 k allocs: 0.155 MB 1
Simulations/StaticMechanicalDirichlet 1.51 M allocs: 0.109 GB 1.51 M allocs: 0.109 GB 1
Simulations/StaticMechanicalNeumann 1.48 M allocs: 0.0933 GB 1.48 M allocs: 0.0933 GB 1
Simulations/ViscoElastic 0.343 G allocs: 22 GB 0.343 G allocs: 22 GB 1
Tensor algebra/Cofactor 1 allocs: 0.0781 kB 1 allocs: 0.0781 kB 1
Tensor algebra/Det(A)Inv(A') 4 allocs: 0.25 kB 4 allocs: 0.25 kB 1
Tensor algebra/δδ_λ_2d 0 allocs: 0 B 0 allocs: 0 B
Tensor algebra/δδ_μ_2d 0 allocs: 0 B 0 allocs: 0 B
time_to_load 0.149 k allocs: 11.1 kB 0.159 k allocs: 11.6 kB 0.964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant