Perform modpack type detection as needed#5768
Open
Keksilton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have encountered a performance issue with import performance of a large modpack exported with MultiMC.
Profiling pointed me to
findFolderOfFileInZipmethod.Currently all classifications are performed regardless if they are needed based on the priority logic.
With this change specific modpack classifications are performed as needed. This limits the number of calls to
findFolderOfFileInZipduring zip import.For my case and hardware it brings the import time down from 36 seconds to 2 seconds.
While this code change is far from a perfect solution, I believe it's a step in the right direction.
I'm not a C++ developer, so I'm not sure what would be a good way to speed up zip traversal in this context.