Repository navigation
fix(genesis): consume device-plane DR lifecycle - #2523
Merged
Merged
Conversation
…cle' into dev/issue-472-ray-perception
feat: integrate public rich ray perception queries
feat(genesis): support ROCm collector runtime
feat: compose parkour ray patterns downstream
…cle' into dev/issue-472-ray-perception
feat: consume dynamic ray frames and geometry
…ic-dr feat(genesis): enable FlashMimic G1 DR subset
chore(genesis): remove ROCm investigation scaffolding
Collaborator
Author
|
Current head Validation at this head:
The only remaining merge blocker shown by GitHub is review approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
UniLab integration for #2520: consume the unified, device-resident Genesis runtime DR contract and remove the stale owner/docs claim that Genesis tensor reset cannot randomize PD gains.
Closes #2520.
Changes
pd_gainsis enabled through the device-plane packed resetkp/kdlane.Validation
uv run --no-sync pytest -q tests/base/test_genesis_backend.py tests/envs/mdp/test_events.py tests/base/test_reset_state.py tests/envs/locomotion/g1/test_g1_owner_contract.py tests/config/test_g1_motion_tracking_owners.py tests/envs/test_env_configs.py tests/scripts/test_check_docs.py tests/scripts/test_support_matrix.py— 146 passed.uv run --no-sync pytest -q -m slow tests/envs/locomotion/g1/test_g1_owner_contract.py::test_g1_walk_flat_genesis_owner_real_runtime_smoke— 2 passed on RTX 4090 / Genesis 1.3.3.uv run --no-sync ruff format --check .,uv run --no-sync ruff check ., test ruff gate,uv run --no-sync mypy src/unilab, anduv run --no-sync pyright— passed.UNILAB_DOCS_SKIP_AUTODOC=1 ... sphinx-build -b html -n ...— build succeeded with the nine pre-existing excluded-toctree warnings.make test-allwas attempted. Check/type gates passed; the non-slow coverage suite reached 2824 passed / 38 skipped / 1 xfailed but stopped at the pre-existing Motrix failure intest_fused_tensor_root_reset_reads_back_world_angular_velocity[motrix]. Re-running that focused test and stashing this branch both reproduce the identical failure onmain, so it is unrelated to this change.make test-benchmark-smoke— 35/35 module imports and 36/36 script imports passed.Dependency status
The public dependency releases are now available and both default and ROCm profiles resolve them from PyPI:
unisim-core==2.2.0uniray[warp]==0.1.0through therayextraThe former sibling-checkout
ray-localpath source is removed. Both lockfiles are regenerated and validate with locked dry-runs.Final validation
make check
PASS
make test-all
PASS
2828 passed, 61 skipped, 374 deselected, 18 warnings
benchmark import smoke: 35/35 module mode, 36/36 script mode