Repository navigation
fix(sim): encode fused root angular reset in root frame - #2513
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write_root_state_tensor()andwrite_motion_state_tensor()now share a device-resident encoder: linear velocity stays world-frame, while angular velocity is rotated withquat_apply_inverse(root_quat, w_world)into generalized free-root/body-frameqvel.MotionCommandmotion resets for rotated roots and nonzero world angular velocity.Linked Work
mainValidation
make test-allpassed on the final local head before this PR was created or updatedCommands actually run:
Remote CI route:
main: current-head CI is requested with this PR; status will be checked after GitHub schedules it.Impact
mujoco/motrix/ bothArtifacts
make test-allbenchmark smoke passed)Checklist
Follow-up: run the Motrix parameterized conformance regression in an environment with
motrixsim; it was skipped locally because that optional runtime is not installed.