Skip to content

refactor: intersperse exercises next to instructional content - #182

Merged
dem-extra1 merged 6 commits into
mainfrom
refactor/intersperse-exercises
Oct 7, 2026
Merged

dem-extra1 merged 6 commits into
mainfrom
refactor/intersperse-exercises

Conversation

@d-morrison

@d-morrison d-morrison commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Closes #181

Summary

Intersperses all 54 calculus review exercises and worked solutions from Miller (2016) (@problifesavercalc) directly next to the instructional content (definitions, theorems, rules, and worked examples) they reinforce, replacing the previous monolithic end-of-section exercise blocks.

Changes

  • Modularized Subfiles: Split monolithic calculus review files into 54 individual exercise files under _subfiles/calculus-review/_exr-miller-*.qmd alongside formal definitions _def-taylor-polynomial.qmd and _exm-taylor-polynomial-exponential.qmd in _subfiles/derivatives/.
  • 1D Derivatives (_calc-derivatives.qmd):
    • Power rule exercises placed after #thm-deriv-polynomial
    • Log simplification exercise placed after #thm-deriv-log
    • Product rule & second derivative of product placed after #thm-product-rule
    • Quotient rule exercise placed after #thm-quotient-rule
    • Chain rule & composite derivatives placed after #thm-chain-rule
    • Log chain rule & second derivative with constant placed after #cor-deriv-log-chain
    • Critical points & tangent line exercises placed after _def-critical-point.qmd and _def-tangent-line.qmd
    • Taylor series exercises placed directly under ### Taylor series following #def-taylor-polynomial
  • 1D Integrals (_calc-integrals.qmd & _subfiles/_calc_integrals_ftc.qmd):
    • Definite integral, power, symmetry, substitution, and by-parts exercises placed after _exm-evaluation-bracket.qmd
    • Improper Gaussian and uniform density convolution exercises placed after _exm-ftc-cdf-pdf.qmd
  • Partial Derivatives (_subfiles/_sec_vector_calc.qmd):
    • First-order partials, Gaussian density parameters, and symmetric functions placed after _exm-partial-derivative.qmd
    • Partial derivative with respect to an unreferenced variable placed after _exm-constant-wrt-vector.qmd
  • Double Integrals (calculus.qmd):
    • Non-rectangular / triangular double integrals placed after _exm_fubini_nonrect.qmd
    • Rectangular double integrals (polynomial, separable, radical, affine, harmonic identity) placed after _exm_fubini_rect.qmd
  • Attribution & Cross-References: Preserved in Further reading across calculus.qmd and vector-calculus.qmd; all section links and intra-exercise cross-references updated and verified.

@d-morrison
d-morrison marked this pull request as ready for review October 7, 2026 05:29
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


No build artifacts, R files, WORDLIST, or bibliography changes in this round — clean on build hygiene.

Review: PR #182 — "refactor: intersperse exercises next to instructional content"

What changed since the last round (2f1898df..c897105f): Two non-merge commits on the PR branch:

  1. 616ce26 "Add specific Question 1.1.X attributions and trigonometric rules" — adds per-exercise Adapted from @problifesavercalc, Question 1.1.X. attribution lines to all 54 split exercise files (directly addressing the prior round's observation Import the math prerequisites #2 about the dropped per-exercise callout), adds two new theorem divs #thm-deriv-sin/#thm-deriv-cos to _calc-derivatives.qmd, and adds two rows (sin/cos) with an updated citation sentence to the basic-integration-rules table in _subfiles/antiderivatives/_thm-integral-rules.qmd.
  2. c897105 "Include sine Taylor series example in calculus notes" — adds a new worked example _subfiles/derivatives/_exm-taylor-polynomial-sine.qmd and includes it in _calc-derivatives.qmd, alongside a (file-stat-listed, but actually part of commit 616ce26) new cosine Taylor-series example file.

Verification performed:

  • Extracted and read the actual Miller (2016) Probability Lifesaver: Calculus Review Problems PDF (cited as @problifesavercalc, URL confirmed live and matching references.bib) and cross-checked all 54 new "Question 1.1.X" attributions against the source's problem statements and section boundaries (1–15 Derivatives, 16–30 Taylor Series, 31–41 Integrals, 42–46 Partial derivatives, 47–54 Double integrals). Every single one matches exactly, in order, with no duplicates or off-by-one errors — spot-checked Q1.1.3 (chain rule w/ log), Q1.1.5 (Gaussian kernel), Q1.1.11 (critical points of $4x^3-3x^2$) against the source text directly.
  • Verified the math in both new worked examples: the sine Taylor series ($f^{(2k)}(0)=0$, $f^{(2k+1)}(0)=(-1)^k$, series $=\sum (-1)^k x^{2k+1}/(2k+1)!$) and cosine Taylor series ($f^{(2k)}(0)=(-1)^k$, $f^{(2k+1)}(0)=0$, series $=\sum(-1)^k x^{2k}/(2k)!$) are both correct.
  • Confirmed \ba...\ea (aligned-math macro) used in the new cosine example is a real, widely-used macro from latex-macros/macros.qmd.
  • Confirmed \deriv{x} used in the two new theorems ($$\deriv{x}\sin x = \cos x$$, $$\deriv{x}\cos x = -\sin x$$) matches the pre-existing usage pattern already in this exact file for the constant/linearity/power rules (_calc-derivatives.qmd:68,83,99) — even though latex-macros/interpretations.tsv glosses \deriv as a "partial derivative operator," the file already overloads it for ordinary derivatives, so this is consistent with established local convention, not a new defect.
  • Confirmed the new @larsonCalc11e sin/cos integration-rule rows are correct ($\int \sin x,dx = -\cos x$, $\int \cos x,dx = \sin x$) and that the citation sentence was updated to cover them; larsonCalc11e is a real, pre-existing bibliography entry.
  • Confirmed thm-deriv-sin/thm-deriv-cos are unique IDs repo-wide (no collisions) and that cross-references resolve by ID (not position), so inserting them doesn't disturb any existing @thm-... numbering.
  • Confirmed placement of the new sine/cosine Taylor examples in _calc-derivatives.qmd is pedagogically sound: inserted right before the cos-scaled and cos-cubed exercises that build on exactly this Taylor-series knowledge, consistent with the PR's overall "intersperse exercises next to instructional content" goal.
  • Confirmed no _site/, _freeze/, .quarto/, R/, inst/WORDLIST, or references.bib changes in this round; "Maclaurin" (used in the new cosine example) is already in inst/WORDLIST.

Observations (non-blocking)

1. New thm-deriv-sin/thm-deriv-cos theorems are not yet cross-referenced from any solution that uses them — e.g. _subfiles/calculus-review/_exr-miller-deriv-product-poly-cos.qmd:18 computes v'(x) = -\sin x from v(x) = \cos x without citing @thm-deriv-cos, whereas the repo's established convention (seen with @thm-deriv-exp, @thm-deriv-log, and @thm-product-rule in that very same solution) is to cite the specific derivative rule being applied. This file predates the current diff range (not touched by 616ce26/c897105), so it's out of scope to require a fix now — flagging only as a follow-up opportunity now that the sin/cos theorems formally exist.

No bugs, miscomputed math, broken cross-references, or citation inaccuracies found in this round's changes.

Verdict

Ready for merge — this round is a well-verified, accurate response to the prior round's attribution observation (all 54 citations checked against the actual source PDF and confirmed correct) plus two correct, well-placed worked examples. The one earlier open item — checking downstream sites like mlds for links to the four now-removed section anchors — remains the only outstanding non-blocking item from the original review at #182 (comment) (posted 2026-10-07T05:34:38Z) and is unaffected by this round's changes.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "c897105f5a8007312953a4b1b7bdd1f9cf3cf58c",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Checked _calc-derivatives.qmd new thm-deriv-sin/thm-deriv-cos divs and both new Taylor-series example files for math correctness and macro usage; found no defects in the changed paths.",
  "holistic_assessment": "Verified all 54 Question 1.1.X attributions against the actual Miller PDF source for citation accuracy, satisfying the prior round's attribution-scope follow-up without regressing cross-references or build hygiene."
}

Reviewed commit: c897105

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $1.1750 (review) — run

@dem-extra1
dem-extra1 merged commit d0c4a87 into main Oct 7, 2026
16 checks passed
@dem-extra1
dem-extra1 deleted the refactor/intersperse-exercises branch October 7, 2026 07:16
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-07 00:25 PDT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

intersperse exercises next to corresponding instructional content

2 participants